Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-export flat configs "flat/*" #453

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Mar 28, 2024

long-time plan:

v6: no action
v7: rename flat/* => *; eslintrc config * => legacy/*?
v8~: remove eslintrc supports

@aladdin-add aladdin-add force-pushed the feat/re-export-flat-configs branch from e331138 to 058a505 Compare March 28, 2024 10:37
long-time plan:

v6: no action
v7: rename 'flat/*' => '*'; eslintrc config '*' => 'legacy/*'?
v8~: remove eslintrc supports
@aladdin-add aladdin-add force-pushed the feat/re-export-flat-configs branch from 058a505 to 20a090c Compare March 28, 2024 10:38
@aladdin-add aladdin-add force-pushed the feat/re-export-flat-configs branch from d032436 to 042ef40 Compare March 28, 2024 10:54
@bmish
Copy link
Member

bmish commented Mar 28, 2024

I think the plan you've described makes sense and aligns with the recommendation I wrote in eslint/eslint#18095 (comment).

We could also get rid of the direct string imports like require('eslint-plugin-eslint-plugin/configs/recommended') in the next major version.

@aladdin-add
Copy link
Contributor Author

We could also get rid of the direct string imports like require('eslint-plugin-eslint-plugin/configs/recommended') in the next major version.

I think it's fine to keep it, as long as it doesn't come with large maintenance costs. :)

@aladdin-add aladdin-add marked this pull request as ready for review March 29, 2024 02:20
@aladdin-add aladdin-add requested a review from bmish March 29, 2024 02:21
@bmish
Copy link
Member

bmish commented Mar 29, 2024

We could also get rid of the direct string imports like require('eslint-plugin-eslint-plugin/configs/recommended') in the next major version.

I think it's fine to keep it, as long as it doesn't come with large maintenance costs. :)

It doesn't have much maintenance cost, but long-term, I still think it's preferable to standardize on a single means of using flat config with the standard configs object.

@aladdin-add aladdin-add merged commit e3b27e2 into main Apr 1, 2024
12 checks passed
@aladdin-add aladdin-add deleted the feat/re-export-flat-configs branch April 1, 2024 10:17
@aladdin-add
Copy link
Contributor Author

yes, we can remove them all when dropping the eslintrc supports. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants