feat: preparing for eslint v9 #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
force-pushed
the
fix/eslint-v9
branch
4 times, most recently
from
d06e514 to
d42b905
Compare
aladdin-add
force-pushed
the
fix/eslint-v9
branch
4 times, most recently
from
a79f7a5 to
bf29cc7
Compare
as the node is required to use the new `sourceCode.getScope(node)` API.
it set the coverage threshold to 95% for branches, 99% for lines.
aladdin-add
force-pushed
the
fix/eslint-v9
branch
from
bf29cc7 to
0faa4e6
Compare
aladdin-add
commented
Dec 10, 2023
.nycrc
Outdated
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "branches": 94, | |||
There was a problem hiding this comment.
adding the config as the check coverage fails (<99%). but I think it's covered tho:
- sourceCode.xxx was covered when running eslint v8.
- context.xxx was covered when running eslint v7.
bmish
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/