feat!: Add missing deprecated/replacedBy properties to meta-property-ordering rule
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
aladdin-add
reviewed
Nov 9, 2022
docs/rules/meta-property-ordering.md
Outdated
| @@ -12,7 +12,7 @@ This rule enforces that meta properties of a rule are placed in a consistent ord | |||
|
|
|||
| This rule has an array option: | |||
|
|
|||
| * `['type', 'docs', 'fixable', 'hasSuggestions', 'schema', 'messages', 'deprecated', 'replacedBy']` (default): The order that the properties of `meta` should be placed in. | |||
| * `['type', 'docs', 'fixable', 'hasSuggestions', 'deprecated', 'replacedBy', 'schema', 'messages']` (default): The order that the properties of `meta` should be placed in. | |||
There was a problem hiding this comment.
imo, the two props should be highlighted, what do you think change them to be in the 1st place?
There was a problem hiding this comment.
Sure, I would be open to that.
aladdin-add
changed the title
deprecated/replacedBy properties to meta-property-ordering ruledeprecated/replacedBy properties to meta-property-ordering rule
aladdin-add
approved these changes
Apr 9, 2024
aladdin-add
deleted the
meta-property-ordering-missing-deprecated-replacedBy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
deprecated,replacedByrule metadata properties were mentioned in the rule doc but not actually enforced by the rule.I have inserted these properties into the default list right after
fixable/hasSuggestions. I'm leavingschema/messageslast in the list since these are potentially large objects/arrays, and we should keep the essential, concise/one-line properties together.This is a breaking change that can go in with #269.