Fix beam crash when resetting call_time/memory while tracing #8897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearing the BpDataCallTrace hashes under the feet of executing processes could cause crash. Instead allocate a new cleared BpDataCallTrace for the staged breakpoint.
into 'sverker/26/erts/trace-bp-hash-reset-bug/erlangGH-8835/OTP-19269'
into sverker/27/erts/trace-bp-hash-reset-bug/erlangGH-8835/OTP-19269
sverker
added
team:VM
CT Test Results 3 files 143 suites 49m 41s ⏱️ Results for commit 212d454. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
vkatsuba
reviewed
Oct 3, 2024
| after 0 -> loop_aaa_bbb() | ||
| end. | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8835.
Resetting counters of
call_timeorcall_memorytracing of a function while it's called by other process could cause the beam VM to crash. This is an old bug that has existed since OTP R16.