-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React simple router and AsyncProps #831
Comments
@sars can you create PR? Trying to do that a while to fit my use case, it would be awesome to look at working example 👍 |
https://github.com/erikras/react-redux-universal-hot-example/pull/833/files @asaf, @svrcekmichal Something like this... Hope it's not too big |
waiting for ryanflorence/async-props#42 |
Uh this seems to remove quite some code! I'm trying to build a client-side-only version of this "boilerplate" and it helps a lot to make it simpler! |
@erikras , please, have a look: Do you like this idea? |
👍🏻 I do. |
Can we close this in favor of #833? |
@sars says he's gonna do redo #833 better. #833 (comment) I say close 'em both in favor of his new one. |
I'd propose to migrate to React simple router and AsyncProps (it replaces connectData)
I've already moved to this stack on my project and satisfied so far.
If you want - I can try to make PR for this project as well
The text was updated successfully, but these errors were encountered: