Skip to content

Commit

Permalink
release-22.1: Revert cockroachdb#98150
Browse files Browse the repository at this point in the history
This reverts cockroachdb#98150 because we think it introduced a problem that was detected
via the `replicate/wide` roachtest[^1]. It seems that for reasons still unknown
we do rely on the periodic gossip trigger on liveness lease extensions.

[^1]: cockroachdb#99268 (comment)

Touches cockroachdb#99268.
Touches cockroachdb#97966.
Closes cockroachdb#99268.
Touches cockroachdb#98945.

Epic: none
Release note: None
  • Loading branch information
erikgrinaker committed Mar 27, 2023
1 parent 5e1b4ea commit b1c4c67
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/kv/kvserver/replica_proposal.go
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ func (r *Replica) leasePostApplyLocked(
// seconds) in any case due to the liveness heartbeats. And the system config
// will be gossiped rarely because it falls on a range with an epoch-based
// range lease that is only reacquired extremely infrequently.
if leaseChangingHands && iAmTheLeaseHolder {
if iAmTheLeaseHolder {
// NB: run these in an async task to keep them out of the critical section
// (r.mu is held here).
_ = r.store.stopper.RunAsyncTask(r.AnnotateCtx(context.Background()), "lease-triggers", func(ctx context.Context) {
Expand Down

0 comments on commit b1c4c67

Please sign in to comment.