Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Reorg Indexing on Proof-of-Stake #3538

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Fix Reorg Indexing on Proof-of-Stake #3538

merged 2 commits into from
Feb 18, 2022

Conversation

Giulio2002
Copy link
Contributor

No description provided.

@Giulio2002 Giulio2002 changed the title Fix Reorg Indexing Fix Reorg Indexing on Proof-of-Stake Feb 17, 2022
yperbasis
yperbasis reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@yperbasis yperbasis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea is to populate HeaderNumber for PoS blocks during stage_blockhashes, the same as for PoW blocks. Does that approach not work? In other words, what's broken without this fix?

@yperbasis yperbasis added the proof-of-stake "The Merge" related commits label Feb 18, 2022
@yperbasis
Copy link
Member

My idea is to populate HeaderNumber for PoS blocks during stage_blockhashes, the same as for PoW blocks. Does that approach not work? In other words, what's broken without this fix?

Actually, ReadHeaderByHash in handleForkChoice fails w/o this fix.

@yperbasis yperbasis mentioned this pull request Feb 18, 2022
Closed
10 tasks
@yperbasis yperbasis merged commit 5db8692 into devel Feb 18, 2022
@yperbasis yperbasis deleted the fix-merge branch February 18, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yperbasis yperbasis yperbasis approved these changes

Assignees
No one assigned
Labels
proof-of-stake "The Merge" related commits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giulio2002 @yperbasis