Add early return in ComputeTxEnv for state sync transactions
#12315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
approved these changes
Oct 15, 2024
shohamc1
added a commit
that referenced
this pull request
Oct 18, 2024
Refinement from #12315 as this condition should only be allowed under certain cases.
yperbasis
added a commit
that referenced
this pull request
Oct 24, 2024
Cherry pick #12315 into `release/2.61` Co-authored-by: Shoham Chakraborty <[email protected]>
yperbasis
pushed a commit
that referenced
this pull request
Oct 24, 2024
Refinement from #12315 as this condition should only be allowed under certain cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComputeTxEnvrelied ontxIndex < len(block.Transactions())which is violated by Polygon's state sync event transaction. We handle this case by adding an early return for this case, returning only ibs and blockContext which is used during state sync event tracing.Fixes #11701, #12007