Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codehash override index error #11959

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

shohamc1
Copy link
Member

sort.Search returns 0 for when a valid record in systemContractLookup was not found, and when we subtract 1 from it, it leads to an invalid index and a crash.

Fixes #11936

@shohamc1 shohamc1 changed the title Fix crash Fix codehash override index error Sep 12, 2024
@shohamc1 shohamc1 merged commit ec969d5 into release/2.60 Sep 16, 2024
6 checks passed
@shohamc1 shohamc1 deleted the shohamc1/fix-codehash-crash branch September 16, 2024 08:20
@yperbasis yperbasis added this to the 2.60.8-fixes milestone Sep 16, 2024
@yperbasis yperbasis mentioned this pull request Sep 16, 2024
yperbasis added a commit that referenced this pull request Sep 16, 2024
PR #11959  is fine for the latest state, but not for historical access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants