Updated esdc-dns appliance and first compute node installer to configure recursion forwarders #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure recursion forwarders The recursion forwarders will be configured according to DNS resolvers, which were set during installation. Added new esdc-mon mdata: `org.erigones:recursor_forwarders`.
YanChii
requested changes
Jul 9, 2017
| @@ -88,6 +88,7 @@ config-dir={{ recursor_config_dir }} | |||
| # forward-zones Zones for which we forward queries, comma separated domain=ip pairs | |||
| # | |||
| # forward-zones= | |||
| {% if recursor_forward_zones %}forward-zones={{ recursor_forward_zones | join(',') }}{% endif %} | |||
There was a problem hiding this comment.
I think this line is not needed.
https://doc.powerdns.com/md/recursor/settings/#forward-zones
There was a problem hiding this comment.
Yep. Not needed, but does not hurt - just a feature for the pdns ansible role.
| @@ -191,6 +191,7 @@ function _build_vmmanifest() { | |||
| -e "s|@MON_IP@|${MON_IP}|" \ | |||
| -e "s|@ROOT_AUTHORIZED_KEYS@|${ROOT_AUTHORIZED_KEYS}|" \ | |||
| -e "s|@PGSQL_PDNS_PASSWORD@|${PGSQL_PDNS_PASSWORD}|" \ | |||
| -e "s|@PDNS_RECURSOR_FORWARDERS@|.=${DNS_RESOLVERS/,/;}|" \ | |||
There was a problem hiding this comment.
We really should set this mdata conditionally. We don't want to flood (default) Google DNS servers by every recursive query in the cloud. By default, our pdns server should take care of all recursive queries by itself (opposite to asking a "smarthost").
Please add (in pseudo code):
if recursors != 8.8.[48].[48]; then set metadata...
…S servers are used
YanChii
approved these changes
Jul 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recursion forwarders will be configured according to DNS resolvers, which were set during installation.
Added new esdc-mon mdata:
org.erigones:recursor_forwarders.