-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional TFM to remove dependency #587
Comments
Since, netcoreapp3 is out of support, this change doesn't seem necessary. |
@ericsink netcoreapp 3 is just an sample but it could be something higher ie net 5 or 6 & have on the older frameworks the additional dependency which is not needed. |
Oh, I think maybe I see what you're talking about. SQLitePCLRaw.core targets netstandard2.0, and it contains a package reference for System.Memory. If it targeted one of the .NET Core TFMs, it would (IIRC) only need System.Memory for .NET Framework and maybe classic Xamarin. Am I understanding correctly? |
Correct. Happy to submit a pr if u nominate a TFM. I did net core 3 as it is the oldest where it isn't needed. |
Looking over pending issues and saw I meant to add a comment to this one: I do plan to include this change (or something similar), probably as part of an upcoming release that drops support for Xamarin classic. With several different packages in play, I'm pretty sure it'll be a little bit more complicated than just adding a TFM. Thanks. |
Summary
I want there to be an additional TFM for the package so that the dependency on System.Memory can be removed and instead the framework rely upon
Proposal
Add a new TFM ie NetCoreApp 3 and make the system.Memory package dependeny on TFM so it is only included when needed.
The text was updated successfully, but these errors were encountered: