From cee5d3e372a9670801cf11f6c2551a911da7c2eb Mon Sep 17 00:00:00 2001
From: erschef_microsoft <erschef@microsoft.com>
Date: Tue, 10 Dec 2024 10:24:47 -0500
Subject: [PATCH] fix: Update VPN gateway names and serviceShort parameters in
 README and test files

---
 avm/res/network/p2s-vpn-gateway/README.md      | 18 +++++++++---------
 .../tests/e2e/max/main.test.bicep              |  2 +-
 .../tests/e2e/waf-aligned/main.test.bicep      |  2 +-
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/avm/res/network/p2s-vpn-gateway/README.md b/avm/res/network/p2s-vpn-gateway/README.md
index 135a325b68..3b174d1308 100644
--- a/avm/res/network/p2s-vpn-gateway/README.md
+++ b/avm/res/network/p2s-vpn-gateway/README.md
@@ -43,7 +43,7 @@ module p2sVpnGateway 'br/public:avm/res/network/p2s-vpn-gateway:<version>' = {
   name: 'p2sVpnGatewayDeployment'
   params: {
     // Required parameters
-    name: 'vscminp2sVpnGw'
+    name: 'npvgminp2sVpnGw'
     virtualHubResourceId: '<virtualHubResourceId>'
     // Non-required parameters
     associatedRouteTableName: 'defaultRouteTable'
@@ -70,7 +70,7 @@ module p2sVpnGateway 'br/public:avm/res/network/p2s-vpn-gateway:<version>' = {
   "parameters": {
     // Required parameters
     "name": {
-      "value": "vscminp2sVpnGw"
+      "value": "npvgminp2sVpnGw"
     },
     "virtualHubResourceId": {
       "value": "<virtualHubResourceId>"
@@ -105,7 +105,7 @@ module p2sVpnGateway 'br/public:avm/res/network/p2s-vpn-gateway:<version>' = {
 using 'br/public:avm/res/network/p2s-vpn-gateway:<version>'
 
 // Required parameters
-param name = 'vscminp2sVpnGw'
+param name = 'npvgminp2sVpnGw'
 param virtualHubResourceId = '<virtualHubResourceId>'
 // Non-required parameters
 param associatedRouteTableName = 'defaultRouteTable'
@@ -133,7 +133,7 @@ module p2sVpnGateway 'br/public:avm/res/network/p2s-vpn-gateway:<version>' = {
   name: 'p2sVpnGatewayDeployment'
   params: {
     // Required parameters
-    name: 'vscmaxp2sVpnGw'
+    name: 'npvgmaxp2sVpnGw'
     virtualHubResourceId: '<virtualHubResourceId>'
     // Non-required parameters
     associatedRouteTableName: 'noneRouteTable'
@@ -175,7 +175,7 @@ module p2sVpnGateway 'br/public:avm/res/network/p2s-vpn-gateway:<version>' = {
   "parameters": {
     // Required parameters
     "name": {
-      "value": "vscmaxp2sVpnGw"
+      "value": "npvgmaxp2sVpnGw"
     },
     "virtualHubResourceId": {
       "value": "<virtualHubResourceId>"
@@ -243,7 +243,7 @@ module p2sVpnGateway 'br/public:avm/res/network/p2s-vpn-gateway:<version>' = {
 using 'br/public:avm/res/network/p2s-vpn-gateway:<version>'
 
 // Required parameters
-param name = 'vscmaxp2sVpnGw'
+param name = 'npvgmaxp2sVpnGw'
 param virtualHubResourceId = '<virtualHubResourceId>'
 // Non-required parameters
 param associatedRouteTableName = 'noneRouteTable'
@@ -286,7 +286,7 @@ module p2sVpnGateway 'br/public:avm/res/network/p2s-vpn-gateway:<version>' = {
   name: 'p2sVpnGatewayDeployment'
   params: {
     // Required parameters
-    name: 'vscwafp2sVpnGw'
+    name: 'npvgwafp2sVpnGw'
     virtualHubResourceId: '<virtualHubResourceId>'
     // Non-required parameters
     associatedRouteTableName: 'defaultRouteTable'
@@ -320,7 +320,7 @@ module p2sVpnGateway 'br/public:avm/res/network/p2s-vpn-gateway:<version>' = {
   "parameters": {
     // Required parameters
     "name": {
-      "value": "vscwafp2sVpnGw"
+      "value": "npvgwafp2sVpnGw"
     },
     "virtualHubResourceId": {
       "value": "<virtualHubResourceId>"
@@ -370,7 +370,7 @@ module p2sVpnGateway 'br/public:avm/res/network/p2s-vpn-gateway:<version>' = {
 using 'br/public:avm/res/network/p2s-vpn-gateway:<version>'
 
 // Required parameters
-param name = 'vscwafp2sVpnGw'
+param name = 'npvgwafp2sVpnGw'
 param virtualHubResourceId = '<virtualHubResourceId>'
 // Non-required parameters
 param associatedRouteTableName = 'defaultRouteTable'
diff --git a/avm/res/network/p2s-vpn-gateway/tests/e2e/max/main.test.bicep b/avm/res/network/p2s-vpn-gateway/tests/e2e/max/main.test.bicep
index 273a8726ef..3395943aa6 100644
--- a/avm/res/network/p2s-vpn-gateway/tests/e2e/max/main.test.bicep
+++ b/avm/res/network/p2s-vpn-gateway/tests/e2e/max/main.test.bicep
@@ -15,7 +15,7 @@ param resourceGroupName string = 'dep-${namePrefix}-network.p2svpngateway-${serv
 param resourceLocation string = deployment().location
 
 @description('Optional. A short identifier for the kind of deployment. Should be kept short to not run into resource-name length-constraints.')
-param serviceShort string = 'npvgmin'
+param serviceShort string = 'npvgmax'
 
 @description('Optional. A token to inject into the name of each resource. This value can be automatically injected by the CI.')
 param namePrefix string = '#_namePrefix_#'
diff --git a/avm/res/network/p2s-vpn-gateway/tests/e2e/waf-aligned/main.test.bicep b/avm/res/network/p2s-vpn-gateway/tests/e2e/waf-aligned/main.test.bicep
index d55dd01e3c..f1f9984226 100644
--- a/avm/res/network/p2s-vpn-gateway/tests/e2e/waf-aligned/main.test.bicep
+++ b/avm/res/network/p2s-vpn-gateway/tests/e2e/waf-aligned/main.test.bicep
@@ -15,7 +15,7 @@ param resourceGroupName string = 'dep-${namePrefix}-network.p2svpngateway-${serv
 param resourceLocation string = deployment().location
 
 @description('Optional. A short identifier for the kind of deployment. Should be kept short to not run into resource-name length-constraints.')
-param serviceShort string = 'npvgmin'
+param serviceShort string = 'npvgwaf'
 
 @description('Optional. A token to inject into the name of each resource. This value can be automatically injected by the CI.')
 param namePrefix string = '#_namePrefix_#'