Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS files not minified on Archer C2600 (ipq806x) using 1.13.X factory image #924

Closed
d3fz opened this issue Apr 14, 2021 · 2 comments
Closed

Comments

@d3fz
Copy link
Contributor

d3fz commented Apr 14, 2021

After flashing Gargoyle for the first time on a C2600, using the factory image from 1.13.X (Built 20210126-1716 git@0c75cab9) build, I've noticed that none of the JS files in www/js were minified. But all CSS files in www/themes were (but not theme.js).

After that, I did a clean sysupgrade using the image from 1.13.X (Built 20210319-0339 git@396836cd) build, and all JS/CSS files were minified, as expected. Including theme.js.

Did a quick folder size comparison on www/js afterwards, and I was really impressed to see that the changes from #860 made a ~370kB difference in size. That's quite a lot, actually.

Nice!

@lantis1008
Copy link
Contributor

Hey, i'm not seeing this on the latest builds, factory or sysupgrade.
I'd suggest that this isn't an error and more an artifact of one of the community builds "build environment".

@d3fz
Copy link
Contributor Author

d3fz commented Apr 17, 2021

I understand.

Thank you for your feedback.

Closing issue.

@d3fz d3fz closed this as completed Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants