Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new proposed API v0.1.x #5

Open
ericgj opened this issue Apr 1, 2014 · 1 comment
Open

new proposed API v0.1.x #5

ericgj opened this issue Apr 1, 2014 · 1 comment

Comments

@ericgj
Copy link
Owner

ericgj commented Apr 1, 2014

For anyone using this lib, I've rewritten in from scratch in a more functional, less crufty style. The API changes quite a bit, refer to the Readme in the future branch for details.

I've written a shim that partially deals with the transition -- allowing the old-style el, options constructor. However,

  1. if you use something like accordion.select( accordion.panels[i] ), that should be simplified to accordion.select(i) .
  2. the options for custom entry and title classes are not yet implemented. I am not sure I like having these optional because it breaks the structural css. But I may put them back in for flexibility anyway.
  3. there may be other breaking changes I'm not aware of.

Comments on the new API are welcome.
@fredsterss @stephenmathieson

@fredsterss
Copy link

@ericgj chill! 🐔 I will make a PR to put my comments on 🎱 🍷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants