From 6d4509f97aa506997c0e9c08ac0ef7c430fed0d8 Mon Sep 17 00:00:00 2001 From: Ryan Oaks Date: Tue, 21 Feb 2023 17:40:34 -0500 Subject: [PATCH] Fix TestAccBigQueryDatasetAccess_authorizedRoutine and add note about usage (#7319) --- mmv1/products/bigquery/api.yaml | 1 + .../terraform/tests/resource_bigquery_dataset_access_test.go | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/mmv1/products/bigquery/api.yaml b/mmv1/products/bigquery/api.yaml index 354b15a00a5f..b38d0e8a6e1b 100644 --- a/mmv1/products/bigquery/api.yaml +++ b/mmv1/products/bigquery/api.yaml @@ -311,6 +311,7 @@ objects: ~> **Note:** If this resource is used alongside a `google_bigquery_dataset` resource, the dataset resource must either have no defined `access` blocks or a `lifecycle` block with `ignore_changes = [access]` so they don't fight over which accesses should be on the dataset. + Additionally, both resource cannot be modified in the same apply. references: !ruby/object:Api::Resource::ReferenceLinks guides: 'Controlling access to datasets': 'https://cloud.google.com/bigquery/docs/dataset-access-controls' diff --git a/mmv1/third_party/terraform/tests/resource_bigquery_dataset_access_test.go b/mmv1/third_party/terraform/tests/resource_bigquery_dataset_access_test.go index bb1b5a8b8365..38be05350dce 100644 --- a/mmv1/third_party/terraform/tests/resource_bigquery_dataset_access_test.go +++ b/mmv1/third_party/terraform/tests/resource_bigquery_dataset_access_test.go @@ -421,7 +421,6 @@ resource "google_bigquery_routine" "public" { resource "google_bigquery_dataset" "private" { dataset_id = "%{private_dataset}" - description = "This dataset is private" } resource "google_bigquery_dataset_access" "authorized_routine" {