Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job.py throws when there is no temp2 is specified and trying to kill a process #276

Closed
nbayaman opened this issue May 8, 2021 · 3 comments

Comments

@nbayaman
Copy link

nbayaman commented May 8, 2021

$ plotman kill 2f01
Namespace(cmd='kill', idprefix=['2f01'])
Pausing PID 6186, plot id 2f01113f17bf5c7222026ec8bb5cc7d762d2c55c8085f36a5e68a9ba4510b905
Traceback (most recent call last):
  File "/home/nurlan/chia/venv/bin/plotman", line 8, in <module>
    sys.exit(main())
  File "/home/nurlan/chia/venv/lib/python3.8/site-packages/plotman/plotman.py", line 230, in main
    temp_files = job.get_temp_files()
  File "/home/nurlan/chia/venv/lib/python3.8/site-packages/plotman/job.py", line 373, in get_temp_files
    if self.tmpdir in f.path or self.tmp2dir in f.path or self.dstdir in f.path:
TypeError: 'in <string>' requires string as left operand, not NoneType`

line 373:

if self.tmpdir in f.path or self.tmp2dir in f.path or self.dstdir in f.path:

self.tmp2dir should be sanitized here I guess

@altendky
Copy link
Collaborator

altendky commented May 8, 2021

I swear I fixed something like this in the past week... but I can't find it. Anyways, easy enough. Thanks for the report.

@altendky
Copy link
Collaborator

altendky commented May 8, 2021

Give @development a try and let me know if it isn't fixed.

@nbayaman nbayaman changed the title job.py throws when there is now temp2 is specified and trying to kill a process job.py throws when there is no temp2 is specified and trying to kill a process May 10, 2021
@nbayaman
Copy link
Author

I've checked your fixing code, I think it should do. I have dirty patched on my local env for myself, so got rid of the bug. Anyways, I think this issue can be marked as closed.

Thank you for addressing it and great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants