Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event_list.has_schedule_activity_task_failed is not detecting ACTIVITY_TYPE_DOES_NOT_EXIST #20

Open
saverchenkov opened this issue Mar 6, 2014 · 0 comments

Comments

@saverchenkov
Copy link

decisionTask.eventList.failed(activityId) returns false when this activityId is in fact failed.

I tried to trace the code through the debugger, and the way it is implemented right now, activityIdFor in event-list.js on line 19 receives scheduledEventId === undefined

screen shot 2014-03-06 at 3 48 32 pm
screen shot 2014-03-06 at 3 50 56 pm

I was able to fix this issue by doing this:

has_schedule_activity_task_failed: function (activityId) {
   return this._has_eventType_for_activityId(activityId, 'ScheduleActivityTaskFailed');
},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant