From 84357664a37df98ec2b78d3338fa79ec1eca56c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20Mo=CC=88ller?= Date: Sun, 4 Oct 2020 10:23:32 +0200 Subject: [PATCH] Enhancement: Assert that StringProvider::arbitrary() provides all kinds of values --- test/Unit/DataProvider/StringProviderTest.php | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/test/Unit/DataProvider/StringProviderTest.php b/test/Unit/DataProvider/StringProviderTest.php index a7ca1fd1..3977ac0d 100644 --- a/test/Unit/DataProvider/StringProviderTest.php +++ b/test/Unit/DataProvider/StringProviderTest.php @@ -26,11 +26,11 @@ final class StringProviderTest extends AbstractProviderTestCase /** * @dataProvider \Ergebnis\Test\Util\DataProvider\StringProvider::arbitrary() * - * @param string $value + * @param mixed $value */ - public function testArbitraryProvidesString(string $value): void + public function testArbitraryProvidesString($value): void { - self::assertNotSame('', \trim($value)); + self::assertIsString($value); } public function testArbitraryReturnsGeneratorThatProvidesStringsThatAreNeitherEmptyNorBlank(): void @@ -42,6 +42,11 @@ public function testArbitraryReturnsGeneratorThatProvidesStringsThatAreNeitherEm 'string-arbitrary-word' => Util\DataProvider\Specification\Closure::create(static function (string $value): bool { return '' !== $value && '' !== \trim($value); }), + 'string-blank-carriage-return' => Util\DataProvider\Specification\Identical::create("\r"), + 'string-blank-line-feed' => Util\DataProvider\Specification\Identical::create("\n"), + 'string-blank-space' => Util\DataProvider\Specification\Identical::create(' '), + 'string-blank-tab' => Util\DataProvider\Specification\Identical::create("\t"), + 'string-empty' => Util\DataProvider\Specification\Identical::create(''), 'string-untrimmed-carriage-return' => Util\DataProvider\Specification\Pattern::create('/^\r{1,5}\w+\r{1,5}$/'), 'string-untrimmed-line-feed' => Util\DataProvider\Specification\Pattern::create('/^\n{1,5}\w+\n{1,5}$/'), 'string-untrimmed-space' => Util\DataProvider\Specification\Pattern::create('/^\s{1,5}\w+\s{1,5}$/'),