From c8d19acd792c538636cb8ac3bf626ca3561795fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20M=C3=B6ller?= Date: Sat, 1 Oct 2022 12:26:17 +0200 Subject: [PATCH] Fix: Rename named constructor --- CHANGELOG.md | 5 +++++ src/Header.php | 2 +- src/Type/MIT.php | 2 +- test/Unit/HeaderTest.php | 4 ++-- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 61debc75..579d6b59 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), For a full diff see [`1.2.0...main`][1.2.0...main]. +## Changed + +- Renamed `Header::create()` to `Header::createWithReferenceToLicenseFile()` ([#533]), by [@localheinz] + ## [`1.2.0`][1.2.0] For a full diff see [`1.1.0...1.2.0`][1.1.0...1.2.0]. @@ -77,5 +81,6 @@ For a full diff see [`675601b...0.1.0`][675601b...0.1.0]. [#177]: https://github.com/ergebnis/license/pull/177 [#416]: https://github.com/ergebnis/license/pull/416 [#422]: https://github.com/ergebnis/license/pull/422 +[#533]: https://github.com/ergebnis/license/pull/533 [@localheinz]: https://github.com/localheinz diff --git a/src/Header.php b/src/Header.php index a048e797..e10e26b6 100644 --- a/src/Header.php +++ b/src/Header.php @@ -35,7 +35,7 @@ private function __construct( $this->url = $url; } - public static function create( + public static function createWithReferenceToLicenseFile( Template $template, Period $period, Holder $holder, diff --git a/src/Type/MIT.php b/src/Type/MIT.php index 61ba7085..f390b155 100644 --- a/src/Type/MIT.php +++ b/src/Type/MIT.php @@ -40,7 +40,7 @@ private function __construct( $holder, ); - $header = Header::create( + $header = Header::createWithReferenceToLicenseFile( $headerTemplate, $period, $holder, diff --git a/test/Unit/HeaderTest.php b/test/Unit/HeaderTest.php index 1d7f41d1..069e24c6 100644 --- a/test/Unit/HeaderTest.php +++ b/test/Unit/HeaderTest.php @@ -39,7 +39,7 @@ final class HeaderTest extends Framework\TestCase { use Test\Util\Helper; - public function testToStringReturnsStringRepresentation(): void + public function testCreateWithReferenceToLicenseFileReturnsHeader(): void { $faker = self::faker(); @@ -61,7 +61,7 @@ public function testToStringReturnsStringRepresentation(): void ); $url = Url::fromString($faker->url); - $header = Header::create( + $header = Header::createWithReferenceToLicenseFile( $template, $range, $holder,