Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make containerd.sock configurable in your helm charts #647

Closed
mdrakiburrahman opened this issue Feb 24, 2023 · 4 comments · Fixed by #930
Closed

Make containerd.sock configurable in your helm charts #647

mdrakiburrahman opened this issue Feb 24, 2023 · 4 comments · Fixed by #930
Labels
bug Something isn't working
Milestone

Comments

@mdrakiburrahman
Copy link

Microk8s runs containerd in /var/snap/microk8s/common/run/containerd.sock.

Eraser right now hardcodes the containerd socket path as a constant:
https://github.com/Azure/eraser/blob/dce0e838ea638e383ef8d38f68b3b726e64e66bd/pkg/utils/utils.go#L37

Even without Microk8s, this would reduce the usability of eraser in other environments where the socket is installed somewhere else.

This results in Eraser Collector failing in Microk8s:

{"level":"error","ts":1677250961.0918322,"logger":"eraser","msg":"failed to get image client","error":"rpc error: code = Unimplemented desc = unknown service runtime.v1.RuntimeService\nrpc error: code = Unimplemented desc = unknown service runtime.v1alpha2.RuntimeService","stacktrace":"main.main\n\t/workspace/pkg/eraser/eraser.go:71\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:250"}

An easy solution is to expose the Containerd Socket parameter in your Helm chart, and injecting that into Go as a ConfigMap.

Environment:

  • Eraser version: kubectl apply -f https://raw.githubusercontent.com/Azure/eraser/v1.0.0/deploy/eraser.yaml
  • Kubernetes version: (use kubectl version): Microk8s v1.26.1
@pmengelbert
Copy link
Contributor

Thanks @mdrakiburrahman . This is on the backlog, it's an issue with k3s as well.

@salaxander salaxander added this to the v1.2.0 milestone Mar 23, 2023
@sozercan
Copy link
Member

sozercan commented Jun 5, 2023

Should be unblocked by #656

@onedr0p
Copy link

onedr0p commented Nov 27, 2023

Any update on this?

@pmengelbert
Copy link
Contributor

@onedr0p We have @ashnamehrotra picking up on this, so someone will be actively working on it again. Thanks for the bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
5 participants