Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make c/c++ interface private #954

Open
sondreso opened this issue Feb 16, 2024 · 0 comments
Open

Make c/c++ interface private #954

sondreso opened this issue Feb 16, 2024 · 0 comments
Assignees

Comments

@sondreso
Copy link
Contributor

We will make the c/c++ interface of resdata (formerly known as ecl/libecl) private.

The rationale is that there are a lot of functionality that is only exposed in c/c++ which is in little use, and we would like to clean this up in order to have a library that is easier to maintain. ert used to be a big consumer of this interface, but this is not the case anymore. Other users

The next step is ta create a new major version bump of Resdata with the c/c++ interface as private. This means all comments in README and documentation about the c/c++ interface will disappear. Also the following lines will be removed:

return ctypes.CDLL(path, ctypes.RTLD_GLOBAL)

"-DCMAKE_INSTALL_INCLUDEDIR=python/resdata/.include",

Note: The binaries exposed by resdata is still considered public:

resdata/setup.py

Lines 37 to 53 in c62737a

"CF_dump",
"convert.x",
"rd_pack.x",
"rd_unpack.x",
"grdecl_grid",
"grdecl_test.x",
"grid_dump.x",
"grid_dump_ascii.x",
"grid_info.x",
"kw_extract",
"kw_list.x",
"load_test.x",
"make_grid",
"ri_well_test",
"segment_info",
"select_test.x",
"summary.x",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants