Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cancel ert run in gui test #9543

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Dec 13, 2024

Resolves: #9420

This test: test_that_debug_info_button_provides_data_in_clipboard, runs in parallel and often fails with ert run not being properly terminated before the test finishes. I believe it is better to just wait longer for the run to finish instead of trying to cancel it.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj added the release-notes:flaky-test-fix PR fixes a flaky test label Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (0ca408f) to head (cf081aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9543      +/-   ##
==========================================
+ Coverage   91.84%   91.85%   +0.01%     
==========================================
  Files         433      433              
  Lines       26768    26768              
==========================================
+ Hits        24586    24589       +3     
+ Misses       2182     2179       -3     
Flag Coverage Δ
cli-tests 39.78% <ø> (ø)
everest-models-test 34.67% <ø> (ø)
gui-tests 72.12% <ø> (ø)
integration-test 37.26% <ø> (+0.02%) ⬆️
performance-tests 52.00% <ø> (+0.02%) ⬆️
test 40.45% <ø> (-0.03%) ⬇️
unit-tests 74.13% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj self-assigned this Dec 13, 2024
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@larsevj larsevj merged commit e564b57 into equinor:main Dec 13, 2024
39 checks passed
@larsevj larsevj deleted the do_not_cancel_run_in_debug_test branch December 13, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:flaky-test-fix PR fixes a flaky test
Projects
Status: Done
3 participants