Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid version specific sed syntax #9540

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

berland
Copy link
Contributor

@berland berland commented Dec 13, 2024

The argument to sed prior to this change triggers something in sed version 4.6 or 4.7

Issue
Resolves #9539

Approach
Use simpler grep syntax.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland added the release-notes:misc Automatically categorise as miscellaneous change in release notes label Dec 13, 2024
@berland berland self-assigned this Dec 13, 2024
@JHolba
Copy link
Contributor

JHolba commented Dec 13, 2024

tested locally and the new version seems to give the same results as the old 👍

@berland berland force-pushed the fix_porcelain branch 2 times, most recently from c33c6cb to 78e3fbf Compare December 13, 2024 12:00
@berland berland enabled auto-merge (rebase) December 13, 2024 12:01
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (0ca408f) to head (97d8363).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9540      +/-   ##
==========================================
+ Coverage   91.84%   91.87%   +0.02%     
==========================================
  Files         433      433              
  Lines       26768    26768              
==========================================
+ Hits        24586    24592       +6     
+ Misses       2182     2176       -6     
Flag Coverage Δ
cli-tests 39.78% <ø> (ø)
everest-models-test 34.67% <ø> (-0.01%) ⬇️
gui-tests 72.12% <ø> (ø)
integration-test 37.23% <ø> (-0.01%) ⬇️
performance-tests 51.98% <ø> (ø)
test 40.46% <ø> (-0.02%) ⬇️
unit-tests 74.14% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The argument to sed prior to this change triggers something in sed version 4.6 or 4.7

Also solve contamination issues that has crept in.
@berland berland merged commit 1af592d into equinor:main Dec 13, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:misc Automatically categorise as miscellaneous change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

git status --porcelain is not working in CI
3 participants