Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error when everest fm_step reaches MAX_RUNTIME #9522

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Dec 12, 2024

Issue
Resolves #8760

Approach

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava added release-notes:improvement Automatically categorise as improvement in release notes release-notes:formatting PR with only text formatting changes labels Dec 12, 2024
@DanSava DanSava self-assigned this Dec 12, 2024
Also log the error in forward_models.log
@DanSava DanSava force-pushed the report-max-runtime-error branch from 614afa8 to 78a9c4e Compare December 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:formatting PR with only text formatting changes release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reporting for users when the max_runtime limit is reached.
1 participant