Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing params to TorqueQueueOptions when creating Everest server #9431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cmrqs
Copy link

@cmrqs cmrqs commented Dec 3, 2024

Issue
Resolves #9430

Approach
Added the parameters queue and keep_qsub_output to TorqueQueueOptions when creating the Everest server.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@cmrqs cmrqs force-pushed the server-torque-args-fix branch from 1aba6b3 to 6fdd906 Compare December 3, 2024 14:16
@sondreso sondreso requested a review from oyvindeide December 9, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

Everest fails to submit job using OpenPBS driver
2 participants