Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin hook for configuring an activate script on the compute side #9273

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Add plugin hook for configuring an activate script on the compute side #9273

merged 3 commits into from
Nov 27, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Nov 20, 2024 •
edited
Loading

Issue
Resolves #9241

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide force-pushed the forward_path branch 7 times, most recently from 9e7f130 to fcd5b65 Compare November 21, 2024 14:35
@oyvindeide oyvindeide changed the title Forward PATH to compute node Add plugin hook for configuring an activate script on the compute side Nov 22, 2024
@oyvindeide oyvindeide added the release-notes:improvement Automatically categorise as improvement in release notes label Nov 22, 2024
@oyvindeide oyvindeide force-pushed the forward_path branch 2 times, most recently from 8ebe3bf to ca82a37 Compare November 22, 2024 10:28
@oyvindeide oyvindeide marked this pull request as ready for review November 22, 2024 10:30
@oyvindeide oyvindeide force-pushed the forward_path branch 3 times, most recently from 47fe471 to 186a508 Compare November 26, 2024 11:03
sondreso
sondreso approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the documentation and then this is good to go :ship

src/ert/plugins/hook_specifications/activate_script.py Show resolved Hide resolved
@oyvindeide
Create joint submit script
1d62a28
@oyvindeide
Make activate script that runs on compute node
17e775f 
Without this we rely on some external mechanism to make sure we have
the required environment on the compute cluster, for example the user
sourcing their vitrualenvironment in their bashrc/cshrc file.
@oyvindeide
Make sure driver is polled for status
e158c22
@oyvindeide oyvindeide enabled auto-merge (rebase) November 27, 2024 19:02
@oyvindeide oyvindeide merged commit 403a55e into equinor:main Nov 27, 2024
40 checks passed
@oyvindeide oyvindeide deleted the forward_path branch November 27, 2024 19:28
@cmrqs cmrqs mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreso sondreso sondreso approved these changes

Assignees
No one assigned
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix running Everest on LSF
2 participants
@oyvindeide @sondreso