-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store everest results in ERT storage #9161
base: main
Are you sure you want to change the base?
Store everest results in ERT storage #9161
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9161 +/- ##
==========================================
+ Coverage 90.70% 90.72% +0.02%
==========================================
Files 351 351
Lines 21903 21908 +5
==========================================
+ Hits 19867 19876 +9
+ Misses 2036 2032 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7081e58
to
32193bd
Compare
5b54ee7
to
dda3db9
Compare
fb5948d
to
a737a84
Compare
@@ -437,6 +426,8 @@ def run_experiment( | |||
self._result = OptimalResult.from_seba_optimal_result( | |||
seba_storage.get_optimal_result() # type: ignore | |||
) | |||
optimal_result_from_everstorage = self.ever_storage.get_optimal_result() | |||
assert self._result == optimal_result_from_everstorage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This is temporary/sanity check to be removed. If all tests pass with this, it means the storage is producing the same optimal results as the old. )
3b6d06d
to
8583aa9
Compare
98b447a
to
84d7248
Compare
(will be split into nicer commits)
84d7248
to
14b9e4a
Compare
Issue
Resolves #8811
Store it as some dataframes and dump it in storage, not entirely sure how much of it should be saved. Will use everest_data_api as reference for what is required.
Objectives, constraints and control names are pivoted so that each distinct value has its own column, which is more concise and better to serve via an API. It makes each row in the dataset represent the entire set of controls, objectives, and constraints for one
batch | batch -> realization | batch -> realization -> perturbation
.Objective results:
Gradient results: