Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capturing of ForwardModelStepWarning #8857

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 3, 2024

Fixes an issue where ForwardModelStepWarning did not show in Suggestor

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Oct 3, 2024
@eivindjahren eivindjahren force-pushed the fix_capture_of_validation branch from 90ad7e0 to 1fe7ce2 Compare October 3, 2024 07:45
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good improvement :)

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.34%. Comparing base (4bba695) to head (87ed7d4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/gui/main.py 88.88% 2 Missing ⚠️
src/ert/config/capture_validation.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8857      +/-   ##
==========================================
- Coverage   91.35%   91.34%   -0.01%     
==========================================
  Files         343      344       +1     
  Lines       21087    21102      +15     
==========================================
+ Hits        19263    19276      +13     
- Misses       1824     1826       +2     
Flag Coverage Δ
cli-tests 39.61% <31.91%> (+0.04%) ⬆️
gui-tests 73.53% <93.61%> (+0.04%) ⬆️
performance-tests 50.20% <36.17%> (+0.03%) ⬆️
unit-tests 79.91% <89.36%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren force-pushed the fix_capture_of_validation branch from 1fe7ce2 to 87ed7d4 Compare October 3, 2024 08:06
@eivindjahren eivindjahren enabled auto-merge (rebase) October 3, 2024 08:06
@eivindjahren eivindjahren merged commit 59eb4f3 into equinor:main Oct 3, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants