-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate and show lsf exec_hosts in run_dialog label #8824
Conversation
bff30e5
to
757acbe
Compare
Should we do an attempt to obtain a FQDN when printing the hostnames? |
757acbe
to
efb2240
Compare
We could.
Do note that |
Right. Maybe just better print the string as-is from bjobs to avoid having to parse something we don't really control. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8824 +/- ##
=======================================
Coverage 91.42% 91.43%
=======================================
Files 344 344
Lines 21120 21140 +20
=======================================
+ Hits 19309 19329 +20
Misses 1811 1811
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fd360c8
to
6d1908a
Compare
There was an additional comment on the original issue;
In my opinion the most valuable of these might be the |
6d1908a
to
028a112
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Issue
Resolves #999
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable