Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate and show lsf exec_hosts in run_dialog label #8824

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Sep 30, 2024

Issue
Resolves #999

Screenshot 2024-10-04 at 15 11 09

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland
Copy link
Contributor

berland commented Oct 3, 2024

Should we do an attempt to obtain a FQDN when printing the hostnames?

@andreas-el
Copy link
Contributor Author

Should we do an attempt to obtain a FQDN when printing the hostnames?

We could.
Currently bjobs will output like this;

(rhel8-bleed-py38-env + bleeding-py38-rhel8) [andrli@st-lintgx0264 komodo]$ bjobs -noheader -o "jobid stat exec_host" 568264
568264 RUN 4*st-rsb17-17-04

Do note that 4*st-rsb17-17-04 is not a valid hostname, but I thought this would be useful to see how many slots were assigned on that specific node.

@andreas-el andreas-el changed the title Bjobs exec hosts Propagate and show exec_hosts in run_dialog label Oct 3, 2024
@andreas-el andreas-el changed the title Propagate and show exec_hosts in run_dialog label Propagate and show lsf exec_hosts in run_dialog label Oct 3, 2024
@berland
Copy link
Contributor

berland commented Oct 3, 2024

Do note that 4*st-rsb17-17-04 is not a valid hostname, but I thought this would be useful to see how many slots were assigned on that specific node.

Right. Maybe just better print the string as-is from bjobs to avoid having to parse something we don't really control.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.43%. Comparing base (8fef8f4) to head (028a112).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8824   +/-   ##
=======================================
  Coverage   91.42%   91.43%           
=======================================
  Files         344      344           
  Lines       21120    21140   +20     
=======================================
+ Hits        19309    19329   +20     
  Misses       1811     1811           
Flag Coverage Δ
cli-tests 39.56% <32.00%> (-0.03%) ⬇️
gui-tests 73.52% <84.00%> (+0.02%) ⬆️
performance-tests 50.14% <40.00%> (-0.04%) ⬇️
unit-tests 80.12% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-el andreas-el force-pushed the bjobs_exec_hosts branch 3 times, most recently from fd360c8 to 6d1908a Compare October 4, 2024 13:08
@andreas-el
Copy link
Contributor Author

There was an additional comment on the original issue;

While at it, perhaps more realization metadata could be contemplated; RUNPATH, job queue name, LSF log files,

In my opinion the most valuable of these might be the job_queue_name ?
The process of adding this will be identical to what was done for exec_hosts, even so for the tests, so this should be very low hanging fruit atm.

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@berland berland merged commit 80a06be into equinor:main Oct 7, 2024
56 checks passed
@andreas-el andreas-el deleted the bjobs_exec_hosts branch October 8, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GUI] Expose compute node hostname in simulation details
3 participants