Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new IES API #6477

Closed
wants to merge 2 commits into from
Closed

Use new IES API #6477

wants to merge 2 commits into from

Conversation

tommyod
Copy link
Contributor

@tommyod tommyod commented Nov 2, 2023

Playing around with IES and trying to match it to the new API. Very much a draft PR.

Issue
Resolves #6474

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@oyvindeide
Copy link
Collaborator

Will close this as this work was completed in another PR.

@oyvindeide oyvindeide closed this Jan 30, 2024
@tommyod tommyod deleted the new-ies-api branch January 30, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to new iterative ensemble smoother api
2 participants