Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting of rate vectors is wrong #8574

Closed
2 of 13 tasks
sondreso opened this issue Aug 26, 2024 · 0 comments · Fixed by #8671
Closed
2 of 13 tasks

Plotting of rate vectors is wrong #8574

sondreso opened this issue Aug 26, 2024 · 0 comments · Fixed by #8671
Assignees
Labels

Comments

@sondreso
Copy link
Collaborator

sondreso commented Aug 26, 2024

What happened? (You can include a screenshot if it helps explain)

Rate vectors are special in reservoir simulators, in that every data-point is valid backwards in time (but not including) the current time-step. See: https://equinor.github.io/fmu-ensemble/usage.html#rate-handling-in-eclipse-summary-vectors

Rate vectors are currently plotted with linear interpolation between the report steps.

See also: #8572

What did you expect to happen?

We should plot it with steps (using pre) instead:

image

From: https://matplotlib.org/stable/gallery/lines_bars_and_markers/step_demo.html

steps to reproduce

TBD

See internal discussions here

Environment where bug has been observed

  • python 3.8
  • python 3.9
  • python 3.10
  • python 3.11
  • python 3.12
  • macosx
  • rhel7
  • rhel8
  • local queue
  • lsf queue
  • slurm queue
  • openPBS queue
  • used flag --enable-scheduler
@sondreso sondreso added the bug label Aug 26, 2024
@sondreso sondreso moved this to Todo in SCOUT Aug 26, 2024
@xjules xjules self-assigned this Sep 6, 2024
@xjules xjules moved this from Todo to In Progress in SCOUT Sep 6, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in SCOUT Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants