From b89d49d3dc84e49fb03a05e8042d0c9636db9c6f Mon Sep 17 00:00:00 2001 From: Eivind Jahren Date: Wed, 3 Jan 2024 13:50:48 +0100 Subject: [PATCH] Merge checklist sections --- .github/PULL_REQUEST_TEMPLATE.md | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 14906819089..148f7c604c3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,23 +8,18 @@ _Short description of the approach_ (Screenshot of new behavior in GUI if applicable) -## Pre review - -- [ ] Read through the code changes carefully after finishing work -- [ ] Make sure tests pass locally (after every commit!) - [ ] PR title captures the intent of the changes, and is fitting for release notes. +- [ ] Added appropriate release note label +- [ ] Commit history is consistent and clean, in line with the [contribution guidelines](https://github.com/equinor/ert/blob/main/CONTRIBUTING.md). +- [ ] Make sure tests pass locally (after every commit!) -## If applicable +## When applicable - [ ] **When there are user facing changes**: Updated documentation - [ ] **New behavior or changes to existing untested code**: Ensured that unit tests are added (See [Ground Rules](https://github.com/equinor/ert/blob/main/CONTRIBUTING.md#ground-rules)). - [ ] **Large PR**: Prepare changes in small commits for more convenient review - [ ] **Bug fix**: Add regression test for the bug - [ ] **Bug fix**: Create Backport PR to latest release -## Pre merge -- [ ] Added appropriate release note label -- [ ] Commit history is consistent and clean, in line with the [contribution guidelines](https://github.com/equinor/ert/blob/main/CONTRIBUTING.md). -