Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal scroll for PROMOTION component on Mobile view #1312

Closed
NickHaggerty1 opened this issue Oct 13, 2022 · 5 comments
Closed

Horizontal scroll for PROMOTION component on Mobile view #1312

NickHaggerty1 opened this issue Oct 13, 2022 · 5 comments
Assignees
@SvSven
Labels
🌐 Next.js (web) 🚀 ready to deploy Use this if issue is ready to be deployed 🎨 UX

Comments

@NickHaggerty1
Copy link

We would like to have the option to display ALL VARIANTS of the Promotion component to be scrollable/swipeable on mobile view.

Should this be set to default ON? or will this impact on existing promotion examples? And have the option to toggle off?

This should also include the News template example of promotion that pulls in the last 3 at the bottom.
@SvSven
Copy link
Contributor

SvSven commented Nov 15, 2022

Relates to #1373

@SvSven
Copy link
Contributor

SvSven commented Dec 1, 2022

Will be partially solved in #1373

@NickHaggerty1
Copy link
Author

NickHaggerty1 commented Dec 15, 2022 •
edited
Loading

Agreed with Sven that horizontal scroll should be default setting on mobile for all PROMOTION settings. No need to have a toggle option for editors.
This goes for:
(Topic / Magazine / News / - not sure about: People? / Events?)
Content should be centered when displayed.

@NickHaggerty1 NickHaggerty1 mentioned this issue Dec 15, 2022
Closed
@fernandolucchesi fernandolucchesi mentioned this issue Dec 26, 2022
Closed
@SvSven SvSven self-assigned this Jan 11, 2023
@SvSven
Copy link
Contributor

SvSven commented Jan 11, 2023

Handled in #1373

@NickHaggerty1
Copy link
Author

Approved @fernandolucchesi @meols

@SvSven SvSven added the 🚀 ready to deploy Use this if issue is ready to be deployed label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SvSven SvSven

Labels
🌐 Next.js (web) 🚀 ready to deploy Use this if issue is ready to be deployed 🎨 UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SvSven @millianapia @NickHaggerty1