From ce359fc99c2d1355bcf3868d25e75adb0194e978 Mon Sep 17 00:00:00 2001 From: Sven van Steenis Date: Fri, 9 Dec 2022 09:44:02 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=92=A1=20add=20comment=20about=20Carousel?= =?UTF-8?q?=20location=20in=20code=20(#1373,=20#1339)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- web/pageComponents/shared/Carousel/index.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/web/pageComponents/shared/Carousel/index.ts b/web/pageComponents/shared/Carousel/index.ts index 4b8c04408..f9d8144b2 100644 --- a/web/pageComponents/shared/Carousel/index.ts +++ b/web/pageComponents/shared/Carousel/index.ts @@ -1 +1,10 @@ +/** + * This should ideally be in web/components/src/Carousel instead of in web/pageComponents/Carousel + * However, it would seem that the Swiper.js library and Jest do not get along nicely + * See: https://github.com/nolimits4web/swiper/discussions/4969 + * I have tried some of the suggestions in that discussion without much success. Due to the structure of our code, using + * the transformIgnorePatterns causes other issues, since we are exporting all components from web/components/src/index.ts + * and we can't selectively ignore just the export line for the Carousel there + */ + export * from './Swiper'