Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defining origin #142

Open
ErlendHaa opened this issue Jul 9, 2019 · 2 comments
Open

Defining origin #142

ErlendHaa opened this issue Jul 9, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@ErlendHaa
Copy link
Contributor

A logical file can contain multiple origins, but only one defining origin. The defining origin is defined as the first origin in the first origin set of each logical file [1]. The current implementation puts all objects in a dict, hence the defining origin is lost.

[1] rp66 v1 - 5.2.1: The first Object in the first ORIGIN Set is the Defining Origin for the Logical File in which it is contained
@ShikhaMishra9 ShikhaMishra9 self-assigned this Jul 19, 2019
@ErlendHaa ErlendHaa added the good first issue Good for newcomers label Nov 28, 2019
@ErlendHaa
Copy link
Contributor Author

ErlendHaa commented Nov 24, 2020 •
edited
Loading

We should not implement behaviour, but defining origin should be documented (and a test added)

@AchyuthB
Copy link

How about this?
defining_origin = logical_file.origins[0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AchyuthB @ErlendHaa @ShikhaMishra9