Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript declarations for eds-icons #626

Closed
mimarz opened this issue Sep 23, 2020 · 0 comments · Fixed by #727
Closed

Add typescript declarations for eds-icons #626

mimarz opened this issue Sep 23, 2020 · 0 comments · Fixed by #727
Assignees
@pomfrida
Labels
good first issue icons eds-icons
Milestone
Hacktober Festivus 🎃

Comments

@mimarz
Copy link
Contributor

mimarz commented Sep 23, 2020 •
edited
Loading

Update package.json, rollup.config.js and tsconfig.json with changes need to include typescript declarations in dist

Checkout core-react for help

Make sure you fork the repository and branch from typescript before starting on this issue
@mimarz mimarz added this to the Hacktober Festivus milestone Sep 23, 2020
@mimarz mimarz added icons eds-icons and removed core-react eds-core-react labels Sep 23, 2020
@pomfrida pomfrida self-assigned this Oct 22, 2020
@pomfrida pomfrida mentioned this issue Oct 22, 2020
Merged
@pomfrida pomfrida linked a pull request Oct 22, 2020 that will close this issue
Typescript declarations for eds-icons #727
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomfrida pomfrida

Labels
good first issue icons eds-icons
Projects
None yet
Milestone
Hacktober Festivus 🎃
Development

Successfully merging a pull request may close this issue.

Typescript declarations for eds-icons pomfrida/design-system
2 participants
@mimarz @pomfrida