Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block merging of pull requests when tests are failing #302

Closed
3 tasks
vnys opened this issue Apr 16, 2020 · 1 comment · Fixed by #383
Closed
3 tasks

Block merging of pull requests when tests are failing #302

vnys opened this issue Apr 16, 2020 · 1 comment · Fixed by #383
Labels
High Priority
Milestone
Open up the repos...

Comments

@vnys
Copy link
Member

vnys commented Apr 16, 2020 •
edited
Loading

We have two tests that fail in the develop-branch now:

  • Dialog: Can extend the css for the component
  • Button: Has circular border when variant is icon & focused

Definition of done:

  • Fix failing tests
  • Run tests in Azure Pipelines
  • Set up branch protection rules in Github

Second subtask duplicate of #185
@mimarz
Copy link
Contributor

mimarz commented Apr 16, 2020 •
edited
Loading

We have issue #185 for adding a test step to our azure pipelines

@joharei joharei mentioned this issue Apr 21, 2020
Merged
4 tasks
@vnys vnys added this to the Open up the repository milestone Jun 5, 2020
@vnys vnys mentioned this issue Jun 24, 2020
Merged
@vnys vnys closed this as completed in #383 Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
High Priority
Projects
None yet
Milestone
Open up the repository
Development

Successfully merging a pull request may close this issue.

Add test pipeline for react components
2 participants
@mimarz @vnys