Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidyverse dependency #82

Closed
sbfnk opened this issue Jun 29, 2023 · 1 comment
Closed

Tidyverse dependency #82

sbfnk opened this issue Jun 29, 2023 · 1 comment
Assignees
Labels

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Jun 29, 2023

The package imports tidyverse, which is discouraged:
https://www.tidyverse.org/blog/2018/06/tidyverse-not-for-packages/

It would be good to replace this with the specific packages from the tidyverse that are needed here.

@ntorresd ntorresd self-assigned this Jul 31, 2023
@jamesmbaazam
Copy link
Member

Related to this, there is need to reduce the number of Imports drastically as it is currently quite dependency heavy. Check this note from devtools::check().

checking package dependencies ... NOTE
  Imports includes 21 non-default packages.
  Importing from so many packages makes the package vulnerable to any of
  them becoming unavailable.  Move as many as possible to Suggests and
  use conditionally.

Related to the the agreed holistic approach to taking dependencies action item, it might be worth thinking about identifying ways to cut down on this. I will keep this in mind as I plan the next steps to achieve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants