Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider merging cfr_static() and cfr_rolling() #105

Closed
pratikunterwegs opened this issue Nov 16, 2023 · 3 comments
Closed

Consider merging cfr_static() and cfr_rolling() #105

pratikunterwegs opened this issue Nov 16, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@pratikunterwegs
Copy link
Collaborator

cfr_static() and cfr_rolling() source codes are basically the same. We need to plan on merging them (as least internally if we want to keep both exported functions). I am not yet sure which one should fold under the other but it doesn't make sense to keep them separate.

Originally posted by @Bisaloo in #103 (comment)

@pratikunterwegs
Copy link
Collaborator Author

This issue is slated for brief exploration with the writing of an internal method .cfr_static() without input checks that can be used in cfr_static() and cfr_rolling().

@pratikunterwegs pratikunterwegs self-assigned this Mar 13, 2024
@pratikunterwegs pratikunterwegs added the enhancement New feature or request label Mar 13, 2024
@pratikunterwegs
Copy link
Collaborator Author

After discussing with @adamkucharski I think this is unlikely to be of much benefit as both functions use .estimate_severity() internally. The parts of cfr_rolling() that differ from cfr_static() are required to produce function specific messages, or to reduce unnecessary computation. This code is pretty much as DRY as it can be (at least without effectively vectorising cfr_static()) - alternative suggestions are welcome, but otherwise this issue can probably be closed.

@adamkucharski
Copy link
Member

Agree, limited value to further work on this I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants