-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state flag file in K8s upgrades (#2702) #2766
Add state flag file in K8s upgrades (#2702) #2766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked creation of files for each incremental upgrade?
Just FYI, this PR should fix such issue that I met recently.
|
@atsikham I have not faced issue like that before, do you remember the way to reproduce it so I will be able to verify? |
To reproduce that you need to run K8s upgrade on Ubuntu, interrupt that after the new kubeadm package is installed, and then run again. |
ba67baa
to
33e6a51
Compare
65450f4
to
3f676ab
Compare
3f676ab
to
f3641be
Compare
f3641be
to
a82b85b
Compare
a82b85b
to
8039af8
Compare
ansible/playbooks/roles/upgrade/tasks/kubernetes/gather-static-facts.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: cicharka <[email protected]>
* Replace touch module with copy Signed-off-by: cicharka <[email protected]>
With new approach we are going to check cluster version on each master, so it will not skip upgrade masters block if first master was already upgraded. Signed-off-by: cicharka <[email protected]>
* added usage of update flag for masters and nodes - having single flag file for both was introducing malfunction (incomplete master upgrade flag was removed by tasks in nodes block) * 'Switch apiserver address to local' task is now executed before the upgrade procedure in order to correctly fetch versions of particular masters - without it procedure for some masters could be skipped, because fetched version didn't match host it tried to upgrade Signed-off-by: cicharka <[email protected]>
* introduce initial_cluster_version used to evaluate need of an upgrade Signed-off-by: cicharka <[email protected]>
d3d95be
to
15537d7
Compare
/azp run |
Signed-off-by: cicharka <[email protected]>
Tests passed on Ubuntu 18.04 LTS and Red Hat 7.8. |
flag file for both was introducing malfunction (incomplete master
upgrade flag was removed by tasks in nodes block)
upgrade procedure in order to correctly fetch versions of particular
masters - without it procedure for some masters could be skipped,
because fetched version didn't match host it tried to upgrade
an upgrade
Tested on cluster (Ubuntu machines) containing: