Docker image user permissions fix (#1373) #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rafzei
commented
Jun 23, 2020
rafzei
commented
- got rid of empty continuation line warning
…mpty continuation line warning
seriva
reviewed
Jun 23, 2020
core/src/epicli/Dockerfile
Outdated
| @@ -5,6 +5,7 @@ ARG EPICLI_VERSION | |||
| ARG USERNAME=epiuser | |||
| ARG USER_UID=1000 | |||
| ARG USER_GID=$USER_UID | |||
| ARG SHARED_DIR=/shared | |||
There was a problem hiding this comment.
The the dockerized Epicli expects the /shared director as output. Check /epiphany/core/src/epicli/cli/helpers/Config.py.
My suggestion would be to replace"
ENV DOCKER_CLI Yes
With:
ENV EPICLI_DOCKER_SHARED_DIR $SHARED_DIR
And change the logic of /epiphany/core/src/epicli/cli/helpers/Config.py to reflect this. When people build there own container with a changed SHARED_DIR argument it will always be reflected properly in the Epicli config when dockerized and avoid issues. Also it makes more sence then ENV DOCKER_CLI Yes
seriva
reviewed
Jun 24, 2020
|
|
||
| self._output_dir = None | ||
| if self._docker_cli: | ||
| self._output_dir = '/shared/build/' | ||
| self._output_dir = os.environ.get('EPICLI_DOCKER_SHARED_DIR') |
There was a problem hiding this comment.
please add the /build dir to the path.
seriva
approved these changes
Jun 24, 2020
jetalone85
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.