Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Kibana fails to upgrade from epicli v1.0 to v1.1 (version comparison issue) #2381

Closed
10 tasks done
przemyslavic opened this issue Jun 16, 2021 · 1 comment
Closed
10 tasks done
Assignees
Labels
priority/critical Show-stopper! You better start it now type/bug
Milestone

Comments

@przemyslavic
Copy link
Collaborator

przemyslavic commented Jun 16, 2021

Describe the bug
There is a problem with upgrading Kibana from epicli v1.0 to v1.1 (there is the same version of Kibana but it will be reinstalled because of the condition >=)
The error was: Version comparison: '<' not supported between instances of 'str' and 'int'.

09:01:07 INFO cli.engine.ansible.AnsibleCommand - TASK [upgrade : Kibana | Print versions] ***************************************
09:01:07 INFO cli.engine.ansible.AnsibleCommand - ok: [ci-10todevazubflannel-logging-vm-2] => {
09:01:07 INFO cli.engine.ansible.AnsibleCommand -     "msg": [
09:01:07 INFO cli.engine.ansible.AnsibleCommand -         "Installed version: 1.13.1",
09:01:07 INFO cli.engine.ansible.AnsibleCommand -         "Target version: 1.13.*"
09:01:07 INFO cli.engine.ansible.AnsibleCommand -     ]
09:01:07 INFO cli.engine.ansible.AnsibleCommand - }



09:01:07 INFO cli.engine.ansible.AnsibleCommand - TASK [upgrade : Kibana | Slurp /etc/kibana/kibana.yml] *************************
09:01:07 ERROR cli.engine.ansible.AnsibleCommand - fatal: [ci-10todevazubflannel-logging-vm-2]: FAILED! => {"msg": "The conditional check 'opendistro_for_elasticsearch_defaults.versions[ansible_os_family].opendistro is version(ansible_facts.packages['opendistroforelasticsearch-kibana'][0].version, '>=')' failed. The error was: Version comparison: '<' not supported between instances of 'str' and 'int'\n\nThe error appears to be in '/shared/build/10todevazubflannel/ansible/roles/upgrade/tasks/kibana.yml': line 39, column 11, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n      block:\n        - name: Kibana | Slurp /etc/kibana/kibana.yml\n          ^ here\n"}

How to reproduce
Steps to reproduce the behavior:

  1. Deploy v1.0 cluster with logging component enabled
  2. Upgrade to develop

Expected behavior
The cluster has been upgraded successfully.

Environment

  • Cloud provider: [all]
  • OS: [all]

epicli version: [epicli --version]
develop (v1.1)


DoD checklist

  • Changelog updated (if affected version was released)
  • COMPONENTS.md updated / doesn't need to be updated
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
  • Case covered by automated test (if possible)
  • Idempotency tested
  • Documentation updated / doesn't need to be updated
  • All conversations in PR resolved
  • Backport tasks created / doesn't need to be backported
@to-bar to-bar added this to the S20210617 milestone Jun 16, 2021
@to-bar to-bar self-assigned this Jun 16, 2021
@przemyslavic
Copy link
Collaborator Author

przemyslavic commented Jun 17, 2021

Fixed.
✔️ epicli apply
✔️ epicli re-apply
✔️ epicli upgrade from v0.9 to develop
✔️ epicli upgrade from v1.0 to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/critical Show-stopper! You better start it now type/bug
Projects
None yet
Development

No branches or pull requests

3 participants