Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Replace Pipenv with Poetry #1953

Closed
sk4zuzu opened this issue Jan 13, 2021 · 2 comments
Closed

[FEATURE REQUEST] Replace Pipenv with Poetry #1953

sk4zuzu opened this issue Jan 13, 2021 · 2 comments
Assignees
Milestone

Comments

@sk4zuzu
Copy link
Contributor

sk4zuzu commented Jan 13, 2021

Is your feature request related to a problem? Please describe.
We have problems keeping our docker builds deterministic with pipenv. Poetry seems to have much better algorithms and works faster.

Describe the solution you'd like
Remove pipenv, add poetry.

Describe alternatives you've considered
This issue can be considered as a bugfix really, so NO. 🤭

Additional context
N/A

@sk4zuzu
Copy link
Contributor Author

sk4zuzu commented Jan 13, 2021

Here's the proof, that we are currently unable to casually regenerate Pipfile.lock file (on the other hand poetry works without issues!) 😨 :

epiphany/core/src/epicli/.devcontainer$ pipenv lock --pre
Courtesy Notice: Pipenv found itself running within a virtual environment, so it will automatically use that environment, instead of creating its own for any project. You can set PIPENV_IGNORE_VIRTUALENVS=1 to force pipenv to ignore that environment and create its own instead. You can set PIPENV_VERBOSITY=-1 to suppress this warning.
Locking [dev-packages] dependencies...
Locking [packages] dependencies...
Building requirements...
Resolving dependencies...
✘ Locking Failed!
[ResolutionFailure]:   File "/home/asd/3.7/lib/python3.7/site-packages/pipenv/resolver.py", line 741, in _main
[ResolutionFailure]:       resolve_packages(pre, clear, verbose, system, write, requirements_dir, packages, dev)
[ResolutionFailure]:   File "/home/asd/3.7/lib/python3.7/site-packages/pipenv/resolver.py", line 709, in resolve_packages
[ResolutionFailure]:       requirements_dir=requirements_dir,
[ResolutionFailure]:   File "/home/asd/3.7/lib/python3.7/site-packages/pipenv/resolver.py", line 692, in resolve
[ResolutionFailure]:       req_dir=requirements_dir
[ResolutionFailure]:   File "/home/asd/3.7/lib/python3.7/site-packages/pipenv/utils.py", line 1403, in resolve_deps
[ResolutionFailure]:       req_dir=req_dir,
[ResolutionFailure]:   File "/home/asd/3.7/lib/python3.7/site-packages/pipenv/utils.py", line 1108, in actually_resolve_deps
[ResolutionFailure]:       resolver.resolve()
[ResolutionFailure]:   File "/home/asd/3.7/lib/python3.7/site-packages/pipenv/utils.py", line 833, in resolve
[ResolutionFailure]:       raise ResolutionFailure(message=str(e))
[pipenv.exceptions.ResolutionFailure]: Warning: Your dependencies could not be resolved. You likely have a mismatch in your sub-dependencies.
  First try clearing your dependency cache with $ pipenv lock --clear, then try the original command again.
 Alternatively, you can use $ pipenv install --skip-lock to bypass this mechanism, then run $ pipenv graph to inspect the situation.
  Hint: try $ pipenv lock --pre if it is a pre-release dependency.
ERROR: Could not find a version that matches cryptography<3.0.0,>=1.1.0,>=1.3.4,>=2.1.4,>=2.3.1,>=2.5,>=3.2 (from ansible==2.8.17->-r /tmp/pipenv8mg77_xvrequirements/pipenv-zzn48o20-constraints.txt (line 6))
Tried: 0.1, 0.2, 0.2.1, 0.2.2, 0.3, 0.4, 0.5, 0.5.1, 0.5.2, 0.5.3, 0.5.4, 0.6, 0.6.1, 0.7, 0.7.1, 0.7.2, 0.8, 0.8.1, 0.8.2, 0.9, 0.9.1, 0.9.2, 0.9.3, 1.0, 1.0.1, 1.0.2, 1.1, 1.1.1, 1.1.2, 1.2, 1.2.1, 1.2.2, 1.2.3, 1.3, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.4, 1.5, 1.5.1, 1.5.2, 1.5.3, 1.6, 1.7, 1.7.1, 1.7.2, 1.8, 1.8.1, 1.8.2, 1.9, 2.0, 2.0.1, 2.0.2, 2.0.3, 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.2, 2.2, 2.2.1, 2.2.1, 2.2.2, 2.2.2, 2.3, 2.3, 2.3.1, 2.3.1, 2.4, 2.4.1, 2.4.1, 2.4.2, 2.4.2, 2.5, 2.5, 2.6, 2.6.1, 2.6.1, 2.7, 2.7, 2.8, 2.8, 2.8, 2.9, 2.9, 2.9, 2.9.1, 2.9.1, 2.9.1, 2.9.2, 2.9.2, 2.9.2, 3.0, 3.0, 3.0, 3.1, 3.1, 3.1, 3.1.1, 3.1.1, 3.1.1, 3.2, 3.2, 3.2, 3.2.1, 3.2.1, 3.2.1, 3.3, 3.3, 3.3, 3.3.1, 3.3.1, 3.3.1
There are incompatible versions in the resolved dependencies:
  cryptography (from ansible==2.8.17->-r /tmp/pipenv8mg77_xvrequirements/pipenv-zzn48o20-constraints.txt (line 6))
  cryptography (from azure-multiapi-storage==0.3.7->azure-cli==2.8.0->-r /tmp/pipenv8mg77_xvrequirements/pipenv-zzn48o20-constraints.txt (line 12))
  cryptography (from azure-storage-common==1.4.2->azure-storage-blob==1.5.0->azure-cli==2.8.0->-r /tmp/pipenv8mg77_xvrequirements/pipenv-zzn48o20-constraints.txt (line 12))
  cryptography<3.0.0,>=2.3.1 (from azure-cli==2.8.0->-r /tmp/pipenv8mg77_xvrequirements/pipenv-zzn48o20-constraints.txt (line 12))
  cryptography>=1.1.0 (from adal==1.2.5->azure-cli-core==2.8.0->azure-cli==2.8.0->-r /tmp/pipenv8mg77_xvrequirements/pipenv-zzn48o20-constraints.txt (line 12))
  cryptography>=1.3.4 (from urllib3[secure]==1.26.2->azure-cli==2.8.0->-r /tmp/pipenv8mg77_xvrequirements/pipenv-zzn48o20-constraints.txt (line 12))
  cryptography>=2.1.4 (from azure-keyvault==1.1.0->azure-cli==2.8.0->-r /tmp/pipenv8mg77_xvrequirements/pipenv-zzn48o20-constraints.txt (line 12))
  cryptography>=2.5 (from paramiko==2.7.2->scp==0.13.3->azure-cli==2.8.0->-r /tmp/pipenv8mg77_xvrequirements/pipenv-zzn48o20-constraints.txt (line 12))
  cryptography>=3.2 (from pyopenssl==20.0.1->azure-cli-core==2.8.0->azure-cli==2.8.0->-r /tmp/pipenv8mg77_xvrequirements/pipenv-zzn48o20-constraints.txt (line 12))

@mkyc mkyc added this to the S20210128 milestone Jan 15, 2021
@sk4zuzu sk4zuzu changed the title [FEATURE REQUEST] Replace pipenv with poetry [FEATURE REQUEST] Replace Pipenv with Poetry Jan 17, 2021
@przemyslavic przemyslavic self-assigned this Jan 26, 2021
@przemyslavic
Copy link
Collaborator

I rebuilt the devcontainer, everything was fine.
I managed to deploy the cluster without any problems using vscode.

@mkyc mkyc closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants