Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why it works: Link each section in 3.1 to the section it relates to in the getting started w/ how #91

Closed
seabbs opened this issue Sep 19, 2024 · 4 comments · Fixed by #106
Labels
documentation Improvements or additions to documentation

Comments

@seabbs
Copy link
Contributor

seabbs commented Sep 19, 2024

See title

@seabbs seabbs added the documentation Improvements or additions to documentation label Sep 19, 2024
@seabbs
Copy link
Contributor Author

seabbs commented Sep 20, 2024

@SamuelBrand1 what do you think? Target at the same time as #72 ?

@SamuelBrand1
Copy link
Collaborator

Yeah good shout!

@SamuelBrand1
Copy link
Collaborator

This is a v good issue.

Extra detail: in f2f conversation with @seabbs we've discussed how the approach in the "why it works" vignette is different to underlying approach implemented in primarycensoreddist, and @parksw3 long paper.

In one sense this is good, because they should all be mathematically equivalent, therefore its a handy check and different perspectives on the same problem is good.

On the other hand, it creates a lot of potential confusion if we don't link carefully between ideas/approaches. This issue should aim to make those links.

@parksw3
Copy link

parksw3 commented Sep 20, 2024

I think the math I put down here "proves" the equivalence in case it's useful...: #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
3 participants