Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose integration settings #7

Closed
seabbs opened this issue Aug 30, 2024 · 2 comments
Closed

Expose integration settings #7

seabbs opened this issue Aug 30, 2024 · 2 comments
Labels
wontfix This will not be worked on

Comments

@seabbs
Copy link
Contributor

seabbs commented Aug 30, 2024

We should consider exposing integration settings in both stan and R. For stan the only thing to expose is setting the relative tolerance. This could be nice for compute constrained use cases but the downside is we can't set defaults in stan easily so doing so could reduce readability. One option could be to overload just a few functions with defaults set but the problem with that is we then wouldn't be able to load those functions into R for testing.

@seabbs seabbs added enhancement New feature or request question Further information is requested labels Sep 2, 2024
@seabbs
Copy link
Contributor Author

seabbs commented Sep 6, 2024

Currently we might not want to do this as any change to this setting causes a large increase in model failures (see #34)

@seabbs
Copy link
Contributor Author

seabbs commented Sep 13, 2024

Due to #64 this is now an issue for exposing ODE settings.

@seabbs seabbs added wontfix This will not be worked on and removed enhancement New feature or request question Further information is requested labels Sep 20, 2024
@seabbs seabbs closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant