Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getting started first figure have integer x axis ticks #45

Closed
seabbs opened this issue Sep 6, 2024 · 1 comment
Closed

Make getting started first figure have integer x axis ticks #45

seabbs opened this issue Sep 6, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@seabbs
Copy link
Contributor

seabbs commented Sep 6, 2024

          ![image](https://github.com/user-attachments/assets/eab1b4a6-2bb6-4ff7-a3ec-a1d166857c22)

Given that this is a discretisation should the x-axis here be 0, 1, 2, ...?

Originally posted by @athowes in #43 (comment)

@seabbs seabbs added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Sep 6, 2024
@seabbs
Copy link
Contributor Author

seabbs commented Oct 4, 2024

I just looked ascross the vignettes and this crops up a few times. I think that for consistencies sake and because in the vast majority of these plots something continuous is also being plot the answer is no and the axis is okay being continuous (and so free to pick its own ticks automatically). I'm happy to hear push back on this but if we do make a change I think it should be everywhere. Closing for now but as above reopen if desired.

@seabbs seabbs closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant