Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter simulation settings and text to highlight problem of censoring #68

Open
athowes opened this issue May 29, 2024 · 1 comment
Open
Labels
documentation Improvements or additions to documentation enhancement New feature or request low For a future release

Comments

@athowes
Copy link
Collaborator

athowes commented May 29, 2024

In the current "get started" vignette (note this issue was highlighted in #59), the simulation settings are such that the extent of biased caused by censoring is less than the extent of biased caused by right truncation. See Figure 2.1:

image

This is mentioned in the caption of the figure. It could be beneficial to

  1. Change the simulation settings to make censoring more of an issue,
  2. Extend this figure / section to split out the impact of right truncation and censoring. This may involve plotting more "types" of data, including the continuous data (see e.g. Is there an issue with using a histogram to plot continuous data? #67).

The point is that we don't want readers to go away with the impression that they don't need to adjust for censoring.

@athowes athowes added documentation Improvements or additions to documentation enhancement New feature or request labels May 29, 2024
@athowes
Copy link
Collaborator Author

athowes commented May 29, 2024

Adam to look at Figure 9 in Park et al. SI to decide whether or not to include similar figure in vignette (could be with the changed simulation settings, or without):

image

@athowes athowes self-assigned this May 30, 2024
@athowes athowes added the low For a future release label Aug 8, 2024
@athowes athowes removed their assignment Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request low For a future release
Projects
None yet
Development

No branches or pull requests

1 participant