Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and refactor prior handling #483

Open
seabbs opened this issue Nov 28, 2024 · 1 comment
Open

Review and refactor prior handling #483

seabbs opened this issue Nov 28, 2024 · 1 comment

Comments

@seabbs
Copy link
Contributor

seabbs commented Nov 28, 2024

#474 has made the prior interface somewhat complex in response to a range of edge cases found during that PR (in particular manual priors used for the event windows). It may be possible to simply this interface or at least to reduce to complexity exposed to the user.

This issue is probably blocked by #221 as that model may have other prior needs that factor into this refactor.

@athowes
Copy link
Collaborator

athowes commented Dec 3, 2024

Agree this makes sense to tackle after adding the marginal model (#221).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants