Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of observe_process #291

Closed
athowes opened this issue Sep 9, 2024 · 2 comments
Closed

Refactor of observe_process #291

athowes opened this issue Sep 9, 2024 · 2 comments
Labels
high Required for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Sep 9, 2024

observe_process creates columns ptime_daily and stime_daily. This seems to be strange to me. What if the columns are already daily (e.g. #52 (comment))? What if we want something other than daily level of censoring? This suggests function refactoring to me.

@athowes athowes added the medium Nice to have for next release label Sep 9, 2024
@athowes athowes mentioned this issue Sep 9, 2024
9 tasks
@seabbs
Copy link
Contributor

seabbs commented Sep 9, 2024

The current approach is 100% hardcoded for the original paper we need to think carefully about the preprocessing i.e should this function even exist and if it does in what form/how exposed to the user (i.e is it in post on a model object or preprocessing)

This was referenced Sep 13, 2024
@seabbs seabbs added high Required for next release and removed medium Nice to have for next release labels Sep 20, 2024
@athowes
Copy link
Collaborator Author

athowes commented Oct 10, 2024

Dupe of #33

@athowes athowes closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high Required for next release
Projects
None yet
Development

No branches or pull requests

2 participants