-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help user pass newdata
as sensible things (e.g. all strata)
#213
Comments
In terms of keeping things atomic my preference is helper functions outside of the prediction function |
|
I do think we need to have The question for me is say that we provide functionality to generate predictions for all strata, then what values to set for the other columns of For example, say we have a model like
This is a little bit confusing to me. Is there some version of these predictions which is agnostic / integrates out / ... these other variables? Say I want to know about the expected delay distribution for a particular sex. Is there a version of that which isn't a function of the observation time? |
This is a useful blog post: https://www.andrewheiss.com/blog/2021/11/10/ame-bayes-re-guide/#posterior-predictions |
Nice that is useful. It looks like if we can plug into |
|
If we do this with |
I've almost finished writing a first helper function for the new strata. I might suggest we complete adding this function, then create a new issue for interacting with |
Edit: the
Limitations:
Hence:
Other:
|
I think for a first pass we can get a lot of functionality from emmeans and we should do so (i.e just point out to it in the FAQ). I agree its not that bayesian but I am surprised you can't get samples out. Once we have that in place (which is quite good coverage). I think we should think again about these strata functions (or if you have some in place we can do that sooner rather than later). |
Closed as not going to do (unless it's hard to get things working with other packages). |
In #210 we added functionality to produce predictions (of the delay internal and natural scale parameters) via
brms::prepare_prediction
for any family.There is an argument
newdata
as follows:Following @seabbs who IMO correctly summarises where we should go:
Basically, here we need to now help users to specify common
newdata
options.Options as far as I see it are either:
predict_delay_samples
predict_delay_samples
then put the helper functions insidepredict_delay_samples
I probably favour 2. over 1. but could be convinced / not strong.
The text was updated successfully, but these errors were encountered: